[release/13.2] Fix migration from .aspire/settings.json to aspire.config.json#15526
Merged
joperezr merged 2 commits intorelease/13.2from Mar 27, 2026
Merged
[release/13.2] Fix migration from .aspire/settings.json to aspire.config.json#15526joperezr merged 2 commits intorelease/13.2from
joperezr merged 2 commits intorelease/13.2from
Conversation
When the AppHost was found from legacy .aspire/settings.json, the UseOrFindAppHostProjectFileAsync method returned early without calling CreateSettingsFileAsync, so the migration to aspire.config.json never triggered. This fix ensures CreateSettingsFileAsync is called when createSettingsFile is true and the AppHost is found from settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address Copilot review feedback: compute appHostPath relative to .aspire/ directory (not workspace root), normalize to forward slashes, and add a decoy project to ensure the legacy-settings resolution path is actually exercised rather than falling through to directory scanning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15526Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15526" |
Contributor
|
🎬 CLI E2E Test Recordings — 51 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23486676796 |
joperezr
approved these changes
Mar 24, 2026
davidfowl
reviewed
Mar 25, 2026
|
|
||
| if (projectFile is not null) | ||
| { | ||
| if (createSettingsFile) |
Member
There was a problem hiding this comment.
It's true for most user-facing CLI commands that mutate or operate on a project:
┌────────────────────────────┬─────────────┐
│ Command │ Value │
├────────────────────────────┼─────────────┤
│ RunCommand │ true │
├────────────────────────────┼─────────────┤
│ AddCommand │ true │
├────────────────────────────┼─────────────┤
│ UpdateCommand │ true │
├────────────────────────────┼─────────────┤
│ ExecCommand │ true │
├────────────────────────────┼─────────────┤
│ PipelineCommandBase (×2) │ true │
├────────────────────────────┼─────────────┤
│ RestoreCommand │ false │
├────────────────────────────┼─────────────┤
│ AppHostLauncher │ false │
├────────────────────────────┼─────────────┤
│ ExtensionInternalCommand │ false │
├────────────────────────────┼─────────────┤
│ SecretStoreResolver │ false │
└────────────────────────────┴─────────────┘
This was referenced Mar 25, 2026
Member
|
Merging to include this bugfix in 13.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15524 to release/13.2
/cc @mitchdenny
Customer Impact
Testing
Risk
Regression?